Add GitHub Enterprise Support

Strider-CD / strider-github

Github provider for strider

25 stars 34 forks source link

Add GitHub Enterprise Support #56

Closed apiv closed 8 years ago

apiv commented 8 years ago

No octonode yet, wanted to get the fixes in first, so that those of us on enterprise can fully use Strider-CD.

[x] Tested with a github enterprise server, working
[x] Tested with github.com, working

knownasilya commented 8 years ago

Think it would be possible to write some tests? Or will it be too difficult?

apiv commented 8 years ago

I was having trouble coming up with tests to write, as I don't think there is an 'example' github enterprise server we can try to connect to. The only thing I can think of would be to ensure that the environment variables set the appConfig object in ./webapp.js.

Any ideas?

Also, it looks like my checks failed on travis, but they are passing locally. Should I try re-running?

knownasilya commented 8 years ago

Was thinking of setting the options, and then passing in mock data to see if it still works.

apiv commented 8 years ago

I'll give that a shot.

apiv commented 8 years ago

I haven't been able to find a way to test against different set of environment variables, short of doing some hacky things like manually invalidating the require.cache...

It may be too difficult to test around this, but the existing specs do protect the existing functionality.

knownasilya commented 8 years ago

I'll try to release a new version tomorrow.

apiv commented 8 years ago

Great, thanks!