search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Please update version on npm to 2.2.0 #58

Closed cloudlena closed 8 years ago

alexfernandez commented 8 years ago

Yes, please! 2.1.2 is not working for me, always uses localhost:3000.

knownasilya commented 8 years ago

Published. @alexfernandez are you setting your SERVER_NAME and PLUGIN_GITHUB_* envs?

alexfernandez commented 8 years ago

Wow that was quick :)

Yes, I am adding SERVER_NAME, but it was not working with @2.1.2. I am unhappy to report that it is not working either with @2.2.0. I will comment on the relevant issue https://github.com/Strider-CD/strider-github/issues/55.

knownasilya commented 8 years ago

@alexfernandez are you adding the PLUGIN_GITHUB_* envs, you need those for Strider to recognize that you have a github plugin.

alexfernandez commented 8 years ago

Yes, those two too.