search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Use strider_server_name instead of SERVER_NAME for hostname. #59

Closed alexfernandez closed 8 years ago

alexfernandez commented 8 years ago

Solves issue https://github.com/Strider-CD/strider-github/issues/55#issuecomment-171649444. The problem is that Strider is changing the env variable SERVER_NAME to strider_server_name here.

knownasilya commented 8 years ago

Strider uses the values from rc, which parses the envs as 'strider_*' and we use the parsed value here: https://github.com/Strider-CD/strider/blob/e29f0f0466ec1dcbde60460e3d4159096ca61a5c/lib/libconfig.js#L68

alexfernandez commented 8 years ago

You are right, it is working now even without this PR. Closing.

knownasilya commented 8 years ago

I know it's complicated. Once I have time I plan on refactoring the config system to make it less convoluted and easier for first time users.

alexfernandez commented 8 years ago

No problem. Thanks for your lightning quick support!