search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Permit deploy to commits only #64

Closed Voffkaa closed 8 years ago

Voffkaa commented 8 years ago

On pull requests no need to make deploy. Only for commits.

knownasilya commented 8 years ago

Hum, just wondering if this needs a config option or if this is the way it should always be. Anyone have thoughts on this?

Voffkaa commented 8 years ago

It would be very good to add option to select if deploy phase should be passed in dependence of job type.

knownasilya commented 8 years ago

Seems like it would be an option to select multiple items:

Voffkaa commented 8 years ago

Unfortunately can't add frontend part now. Too long to explore Angular :)

Voffkaa commented 8 years ago

It would be something like deploy = branch.deployOnJobType[config.trigger.type] || false at backend

knownasilya commented 8 years ago

I'll keep this open for now, and see if anyone can do the frontend portion eventually.

Voffkaa commented 8 years ago

Ok

Voffkaa commented 8 years ago

Added config option. Frontend: https://github.com/Strider-CD/strider/pull/908

knownasilya commented 7 years ago

Seems like this change doesn't work because config.trigger.type is 'commit' during a PR.