search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Use ssh authentication instead of https #69

Closed mandoz closed 8 years ago

mandoz commented 8 years ago

Fixes: https://github.com/Strider-CD/strider-github/issues/68

knownasilya commented 8 years ago

Just wonder if this commit affects anything else negatively..

mandoz commented 8 years ago

Ah the build just failed. I'll try to look into it.

mandoz commented 8 years ago

Seems unrelated that the build is failing. I have been manually testing and things seem fine on my end. Perhaps someone else could weigh in and tell us if that could affect something else.

cloudlena commented 8 years ago

@mandoz: sorry about that. the unit tests were failing even before you commited. i fixed them. can you please rebase?

mandoz commented 8 years ago

@mastertinner green build :)

PMByrne commented 8 years ago

@mastertinner Any idea on when we will get a release for this? Was wanting to user Strider as our CD tool but not being able to clone over ssh is a blocker. Thank you @mandoz for the pull request. Cannot wait to give this all a try.

knownasilya commented 8 years ago

Should be released today

knownasilya commented 8 years ago

Can be updated via the plugins page and npm as well.

mandoz commented 8 years ago

If you have an existing installation of Strider-CD, you will need to do the following steps after the plugin upgrade:

  1. Remove your project/repo.
  2. Refresh your github repos.
  3. Add the project/repo again.

This is because the value of the authentication method is set at the time the repos are fetched from github.

knownasilya commented 8 years ago

Looks like this change breaks normal usage of the plugin. I think we can put this behind an ENV, e.g. STRIDER_GITHUB_USE_SSH=true.

knownasilya commented 7 years ago

@mandoz does this method require the repo to have the project's ssh key to be in github?