search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Unable to 'run' new projects due to ssh failure (publickey) #70

Open midgethoen opened 8 years ago

midgethoen commented 8 years ago

We've been using strider successfully for a while in our organization. However I noticed today that I cant 'run' newly added projects anymore, because of the following error: Git clone failed with code 500

$ git clone --recursive git@github.com:getyippie/xxx.git . --branch master github 789ms -1
Cloning into '.'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

some digging unveiled that previously added projects are using https and this one is using ssh. which led me to this pr #69

Is this supposed to work out of the box or do I need to manually add these keys?

midgethoen commented 8 years ago

FYI we're using the strider-github for adding projects

knownasilya commented 8 years ago

It should work out of the box. Did you see the last comment on that PR? If you follow that, mainly step 2, does it help?

midgethoen commented 8 years ago

Yes, I did try that..

knownasilya commented 8 years ago

Ok, I think a revert is in order..

midgethoen commented 8 years ago

let me double check if we have all the latest versions before you revert based on this issue

midgethoen commented 8 years ago

we're on strider 1.7.6 and strider-github 2.3.1

knownasilya commented 8 years ago

Ok, I'll try to do the revert later today. In the mean time, you can install strider-github 2.3.0 manually in your strider folder.

midgethoen commented 8 years ago

FYI I It's working again after I installed 2.3.0 thanks for the help!

mandoz commented 8 years ago

Sorry for jumping on this so late. Yeah the issue is, the strider public key needs to be given access to the github repository.

One behavior we could implement out of the box (similar to what most hosted CI solutions do), so to add the public key as a deployment key to the repository on github.

The other use case in which we need to be able to install other private repositories while running the tests, one would need to create a machine user like this: https://documentation.codeship.com/faq/access-to-other-repositories-fails-during-build/

As you can see in this document for example, codeship by default adds a deployment key, and then if the use case requires access to multiple repos during running tests, then they have the documentation for that.

knownasilya commented 8 years ago

@mandoz does this need to be documented? If so could you update the README.