search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Question: Do you need an email address for Github to work? #80

Closed mishfit closed 6 years ago

mishfit commented 6 years ago

This line seems to throw if I don't have a public email displayed on my profile, however, I have two invisible emails setup:

https://github.com/Strider-CD/strider-github/blob/master/lib/webapp.js#L169

if (!profile.emails || !profile.emails.length)

What's more, the next line at which an email is used potentially doesn't care if you do have one or not: https://github.com/Strider-CD/strider-github/blob/master/lib/webapp.js#L181

mail: profile.emails ? profile.emails[0].value : null,

So should one have a public email or not?

obviously one of these lines needs to change

knownasilya commented 6 years ago

That is correct, you need a public email. Good catch