Cleanup webhooks - Githubissues

Strider-CD / strider-github

Github provider for strider

25 stars 34 forks source link

Closed freewil closed 10 years ago

freewil commented 10 years ago

fixed existing webhook tests
removed index.js and made lib/index.js the main in package.json
fixed createHooks logic (response.status is undefined) and added some tests
made verifySignature use constant-time string comparison to protect against timing attacks and added tests

freewil commented 10 years ago

bump

niallo commented 10 years ago

Could you update this PR to merge cleanly?

freewil commented 10 years ago

rebased.

niallo commented 10 years ago

Thanks!