Strider-CD / strider-gitlab

Seamless integration between Strider and GitLab
25 stars 16 forks source link

Should sendJob return true, because if we reach that point in the code, the job has been successfully created? #30

Closed saraf closed 9 years ago

saraf commented 9 years ago

Question about webhooks in the gitlab provider - what is the intent of https://github.com/Strider-CD/strider-gitlab/blob/master/lib/webhooks.js#L47

Because, sendJob does not return anything, so even if a job was created successfully, we still get undefined as a result, and "webhook received, but no branches matched or branch is not active" is logged to the console - https://github.com/Strider-CD/strider-gitlab/blob/master/lib/webhooks.js#L102-L108

knownasilya commented 9 years ago

Looks like that needs some fixing..

saraf commented 9 years ago

will do.

saraf commented 9 years ago

Fixed. Closing.