Closed saraf closed 9 years ago
Question about webhooks in the gitlab provider - what is the intent of https://github.com/Strider-CD/strider-gitlab/blob/master/lib/webhooks.js#L47
Because, sendJob does not return anything, so even if a job was created successfully, we still get undefined as a result, and "webhook received, but no branches matched or branch is not active" is logged to the console - https://github.com/Strider-CD/strider-gitlab/blob/master/lib/webhooks.js#L102-L108
Looks like that needs some fixing..
will do.
Fixed. Closing.
Question about webhooks in the gitlab provider - what is the intent of https://github.com/Strider-CD/strider-gitlab/blob/master/lib/webhooks.js#L47
Because, sendJob does not return anything, so even if a job was created successfully, we still get undefined as a result, and "webhook received, but no branches matched or branch is not active" is logged to the console - https://github.com/Strider-CD/strider-gitlab/blob/master/lib/webhooks.js#L102-L108