Strider-CD / strider-gitlab

Seamless integration between Strider and GitLab
25 stars 16 forks source link

Strider throws when invoked for invalid project #90

Closed oliversalzburg closed 6 years ago

oliversalzburg commented 7 years ago
2017-03-20T09:19:57.713Z - ESC[31merrorESC[39m: TypeError: Cannot read property 'author' of undefined
    at pushJob (/data/strider/strider-gitlab/lib/webhooks.js:75:19)
    at startFromCommit (/data/strider/strider-gitlab/lib/webhooks.js:35:16)
    at receiveWebhook (/data/strider/strider-gitlab/lib/webhooks.js:102:16)
    at Layer.handle [as handle_request] (/data/strider/strider/node_modules/express/lib/router/layer.js:95:5)
    at next (/data/strider/strider/node_modules/express/lib/router/route.js:131:13)
    at projectProvider (/data/strider/strider/lib/middleware.js:118:3)
    at Layer.handle [as handle_request] (/data/strider/strider/node_modules/express/lib/router/layer.js:95:5)
    at next (/data/strider/strider/node_modules/express/lib/router/route.js:131:13)
    at /data/strider/strider/lib/middleware.js:234:7
    at /data/strider/strider/node_modules/mongoose/lib/query.js:2555:18
    at tryCatcher (/data/strider/strider/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/data/strider/strider/node_modules/bluebird/js/release/promise.js:510:31)
    at Promise._settlePromise (/data/strider/strider/node_modules/bluebird/js/release/promise.js:567:18)
    at Promise._settlePromise0 (/data/strider/strider/node_modules/bluebird/js/release/promise.js:612:10)
    at Promise._settlePromises (/data/strider/strider/node_modules/bluebird/js/release/promise.js:691:18)
    at Async._drainQueue (/data/strider/strider/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/data/strider/strider/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.Async.drainQueues (/data/strider/strider/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:649:20)
    at tryOnImmediate (timers.js:622:5)
    at processImmediate [as _immediateCallback] (timers.js:594:5)
oliversalzburg commented 7 years ago

I think my error description and the stack trace are 2 separate issues :P

knownasilya commented 6 years ago

Closing since a guard was added by you. Not sure what the title is about exactly.