Stop user HerokuController from clobbering config

Strider-CD / strider-heroku

Strider plugin for heroku deployment

2 stars 8 forks source link

Stop user HerokuController from clobbering config #6

Closed terraboops closed 9 years ago

terraboops commented 9 years ago

Rename HerokuController -> HerokuUserController
Nest the User Config view in an ng-controller directive

Fixes #5

terraboops commented 9 years ago

There are other options here:

Combine the JavaScript files
Use the technique in this stackoverflow post to extend the HerokuController in the second file
Open a closure in the User.js file, pull out the $scope from the Config.js controller and attach some extra functionality
Some other technique for mixing-in functionality to the HerokuController inside the second file...

How do other plugins handle this? Using separate controllers for the project config page and the user config page?

knownasilya commented 9 years ago

Using separate controllers for the project config page and the user config page?

I think that's probably how it's done.

knownasilya commented 9 years ago

I will merge this to make the plugin usable, but if you find a better way, feel free to submit another PR.

terraboops commented 9 years ago

I looked at the other plugins, I couldn't find any other examples of this architecture for configuration pages. I think this solution is probably the way to go, although the ng-controller directive is a bit ugly.

knownasilya commented 9 years ago

We definitely use that directive throughout strider, so no biggie.