search

Strider-CD / strider-mailer

Strider emailing plugin
1 stars 4 forks source link

Does not support secure transport #2

Open kfatehi opened 9 years ago

kfatehi commented 9 years ago

Conventionally, mail sent on port 465 uses TLS, however strider-mailer does not have a way to enable secure transport.

In index.js there are two objects, smtpTransport and smtpConfig which together orchestrate nodemailer. The smtpTransport option could be modified per https://github.com/andris9/nodemailer-smtp-transport#usage to have {secure: true} if the port is 465.

Either that or we expose more configuration to the user through ENV

ref https://github.com/Strider-CD/strider/pull/570

knownasilya commented 9 years ago

Is that the expected behavior? For it to be secure when on port 465?

kfatehi commented 9 years ago

That seems to be the convention as far as I've seen it in configs, etc, but I'd like a 2nd opinion