Strider-CD / strider-node

Run Node.js tests in strider
11 stars 13 forks source link

Remove n #24

Closed oliversalzburg closed 8 years ago

oliversalzburg commented 9 years ago

n is not compatible with Windows and it is only required when targeting a specific node/io version.

While I realize that this might be an important feature to some, it makes it impossible to work with Strider on Windows. And the dependency makes it impossible to even install the plugin, because of the platform limitations in the package.json.

knownasilya commented 9 years ago

You can use the whatever option to just use your version on the system.

oliversalzburg commented 9 years ago

@knownasilya Yeah, that's what I'm doing. But when I try to update the strider-node plugin, it will try to npm install, which fails because n can't be installed on Windows.

knownasilya commented 9 years ago

@oliversalzburg sounds like something to bring up with the n maintainers, since it should be installable even if it's windows.

knownasilya commented 9 years ago

See if others are installable, like nvm or nave, maybe we can switch.

oliversalzburg commented 9 years ago

@knownasilya The n maintainers are aware and are waiting for pull requests. Seems like a daunting task though.

oliversalzburg commented 8 years ago

I've removed the dependency, as n should be installed globally anyway. Now the package can be installed anywhere.