Strider-CD / strider-node

Run Node.js tests in strider
11 stars 13 forks source link

Fix md5 dependency and update case #29

Closed janruehling closed 8 years ago

janruehling commented 8 years ago

Installing strider locally failed for me with the following error:

npm ERR! notarget No compatible version found: md5@'>=1.1.0 <2.0.0'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["1.0.1","1.0.0","2.0.0"]
npm ERR! notarget 
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget 
npm ERR! notarget It was specified as a dependency of 'strider-node'
npm ERR! notarget 

Checking strider-node I found that it had MD5 at ^1.1.0 as a dependency. That version indeed does not exist. After I switched to ^1.0.0 here this error still showed up on install:

npm WARN deprecated MD5@1.3.0: deprecated, use lowercase 'md5@2.x' from now on

So I changed to lowercase md5 and updated "var md5 = require('MD5')" to lowercase md5 where necessary.

knownasilya commented 8 years ago

Does it work with 2.0? Probably better to upgrade to latest if possible.

janruehling commented 8 years ago

Yes it does ...

I didn't update it before since I am just fixing everypaas to get strider running on Heroku again. So I wanted to limit the moving parts.