node_modules caching option causes `path` error

ndhoule commented 10 years ago

Here's the log I'm getting:

20 Dec 02:48:25 - info: [runner:simple-runner] Queued new job. Project: hackreactor/bookstrap2 Job ID: 52b3aff8e0a48f1d4c00001b
20 Dec 02:48:25 - info: [runner:simple-runner] Job started. Project: hackreactor/bookstrap2 Job ID: 52b3aff8e0a48f1d4c00001b
20 Dec 02:48:33 - info: base is: /home/strider/.strider/cache/hackreactor/bookstrap2/node/modules
20 Dec 02:48:33 - info: key is: 04ac644315675d8da194f0df45c6bb8d
20 Dec 02:48:33 - info: base is: /home/strider/.strider/cache/hackreactor/bookstrap2/node/modules
20 Dec 02:48:33 - info: key is: undefined
20 Dec 02:48:33 - info: Job 52b3aff8e0a48f1d4c00001b  domain error caught Arguments to path.join must be strings TypeError: Arguments to path.join must be strings
    at path.js:360:15
    at Array.filter (native)
    at Object.exports.join (path.js:358:36)
    at Function.child.get (/srv/www/hackreactor.com/ci/node_modules/strider-simple-runner/lib/cachier.js:30:15)
    at /srv/www/hackreactor.com/ci/node_modules/strider-node/worker.js:53:15
    at /srv/www/hackreactor.com/ci/node_modules/strider-simple-runner/lib/cachier.js:46:25
    at Object.cb [as oncomplete] (fs.js:168:19)
20 Dec 02:48:33 - error: Job 52b3aff8e0a48f1d4c00001b  Arguments to path.join must be strings TypeError: Arguments to path.join must be strings
    at path.js:360:15
    at Array.filter (native)
    at Object.exports.join (path.js:358:36)
    at Function.child.get (/srv/www/hackreactor.com/ci/node_modules/strider-simple-runner/lib/cachier.js:30:15)
    at /srv/www/hackreactor.com/ci/node_modules/strider-node/worker.js:53:15
    at /srv/www/hackreactor.com/ci/node_modules/strider-simple-runner/lib/cachier.js:46:25
    at Object.cb [as oncomplete] (fs.js:168:19)
20 Dec 02:48:33 - info: [runner:simple-runner] Job done with error. Project: hackreactor/bookstrap2 Job ID: 52b3aff8e0a48f1d4c00001b
20 Dec 02:48:33 - info: [runner:simple-runner] Job done without error. Project: hackreactor/bookstrap2 Job ID: 52b3aff8e0a48f1d4c00001b

The base is: and key is: console logs were added into strider-simple-runner's lib/cachier.js file, between lines 35 and 36. Seems like child.get gets called twice, and that the second time, key is undefined.

Disabling the node_modules caching option in a project's Node settings fixes this error immediately.

Let me know if there's any other info I can provide to help debug this!

ndhoule commented 10 years ago

I should add that this occurs when using either the 0.3.0 or 0.3.3 releases.

jaredly commented 10 years ago

Is the cache populated or empty? On Dec 19, 2013 8:18 PM, "Nathan Houle" notifications@github.com wrote:

I should add that this occurs when using either the 0.3.0 or 0.3.3releases.

— Reply to this email directly or view it on GitHubhttps://github.com/Strider-CD/strider-node/issues/5#issuecomment-30986349 .

knownasilya commented 10 years ago

@ndhoule is this still an issue with the latest version?

Strider-CD / strider-node

node_modules caching option causes `path` error #5