search

Strider-CD / strider-simple-runner

Easy-to-configure in-process Runner implementation for Strider.
MIT License
3 stars 18 forks source link

Tests appear to be currently broken #22

Closed microadam closed 10 years ago

microadam commented 10 years ago

Not sure if its just for me, but I get the following when running "npm test"

1..9
ok 1 JobData with a job get should retrieve the job
ok 2 JobData with a job pop should retrieve and remove the job
ok 3 JobData with a job listeners should propagate to the job
RUNNER INIT
ok 4 Runner should listen for job.new
RUNNER INIT
not ok 5 Runner with a few queued jobs cancelJob should cancel a queued job
  TypeError: Cannot call method 'some' of undefined
      at Object.Runner.plugins (/Users/adam/projects/strider/strider-simple-runner/lib/index.js:242:30)
      at jobDirsReady (/Users/adam/projects/strider/strider-simple-runner/lib/index.js:326:12)
      at /Users/adam/projects/strider/strider-simple-runner/lib/index.js:97:5
      at /Users/adam/projects/strider/strider-simple-runner/node_modules/async/lib/async.js:190:13
      at /Users/adam/projects/strider/strider-simple-runner/node_modules/async/lib/async.js:116:25
      at /Users/adam/projects/strider/strider-simple-runner/node_modules/async/lib/async.js:187:17
      at /Users/adam/projects/strider/strider-simple-runner/node_modules/async/lib/async.js:491:34
      at /Users/adam/projects/strider/strider-simple-runner/node_modules/mkdirp/index.js:38:26
      at Object.oncomplete (fs.js:107:15)
RUNNER INIT
ok 6 Runner with a few queued jobs cancelJob should pass on the cancel event if the job is not queued
ok 7 utils ensureCommand when there are no commands should create a command if there were none
ok 8 utils ensureCommand when the last command is not completed should not add a command
ok 9 utils ensureCommand when the last command has completed should add a command
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0
niallo commented 10 years ago

Yes, they're broken on public-ci too now:

https://public-ci.stridercd.com/strider-cd/strider-simple-runner/job/529bc570b6cad4070000000d