Allow web-hooks to be configured to fire on test or deploy

[ProZachJ]

Fixes #5

I figured out why my web-hook wasn't firing after deploy. The worker was only listening for job.status.tested. So I added a listener for job.status.deployed. Instead of reusing test_exitcode I add a new property to to the payload deploy_exitcode. I also changed the output to say which webhook listener is being fired.

I tested this on my fully updated strider. However I had to remove strider-sauce to work around #4

[ProZachJ]

[jaredly]

This fires all webhooks for both events. Could you add something to the config page to allow the user to specify whether a hook should fire on test or on deploy?

[ProZachJ]

I'll take a look at the UI code and see what I can do.

Should I add a hook for each phase (env, prep, test, deploy, cleanup) and then a check box grid for each web-hook?

[jaredly]

Let's go for simple first - just test and deploy. If people find the need for more than that, we can add it later. I think I'd also prefer to have 1 action per webhook, and let people make multiple hooks if they want multiple actions.

On Sat, Aug 9, 2014 at 7:25 PM, ProZachJ notifications@github.com wrote:

I'll take a look at the UI code and see what I can do.

Should I add a hook for each phase (env, prep, test, deploy, cleanup) and then a check box grid for each web-hook?

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider-webhooks/pull/6#issuecomment-51704194 .

[ProZachJ]

• Working radios that allow you to select which step you would like your web-hook to fire on (test, deploy).
• Listeners are registered and removed based upon job type

ScreenShots:

[ProZachJ]

This still has a bug. The payload field isn't being duplicated in the repeater.

[jaredly]

This looks awesome! Was the payload bug there before your patch, or is it a new regression?

[ProZachJ]

On the master branch the custom payload is outside the repeater. https://github.com/Strider-CD/strider-webhooks/blob/master/config/config.html#L39 Its ng-model is hook.format which doesn't make sense outside of the repeater context (hook in hooks). Looking at it now I'm not sure how its even working as is.

I was trying to add support for a custom format for each web-hook.

[jaredly]

Yeah. I'm ok with just disabling (hiding) that payload field for now

On Mon, Aug 11, 2014 at 3:27 PM, ProZachJ notifications@github.com wrote:

On the master branch the custom payload is outside the repeater.

https://github.com/Strider-CD/strider-webhooks/blob/master/config/config.html#L39 Its ng-model is hook.format which doesn't make sense outside of the repeater context (hook in hooks). Looking at it now I'm not sure how its even working as is.

I was trying to add support for a custom format for each web-hook.

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider-webhooks/pull/6#issuecomment-51849519 .

[ProZachJ]

Here is what I've got right now, just need to test to make sure it works.

[ProZachJ]

Ok try this out, as far as I've tested manually everything is good to go.

Oh also...we wrote a hubot script to listen for the web-hook and post it into any chatroom that your specify in the callback URI.

https://github.com/mattjay/hubot-strider

[jaredly]

Awesome :) Looks like there are some merge conflicts --- could you merge with current master?

[ProZachJ]

Done

[ProZachJ]

Comments added

[ProZachJ]

Any chance this can get merged? I'm having to pull strider from my fork when I want to deploy.

[knownasilya]

@ProZachJ If you could rebase and squash your commits, I'd be willing to merge.

[ProZachJ]

Will do.

On May 13, 2015, at 9:47 AM, Ilya Radchenko notifications@github.com wrote:

@ProZachJ If you could rebase and squash your commits, I'd be willing to merge.

— Reply to this email directly or view it on GitHub.

[knownasilya]

Ping 👍

[ProZachJ]

Wow I totally forgot to do this after I got it working on my server. I'll take a look tonight.

On Jun 2, 2016 7:41 AM, "Ilya Radchenko" notifications@github.com wrote:

Ping 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Strider-CD/strider-webhooks/pull/6#issuecomment-223279474, or mute the thread https://github.com/notifications/unsubscribe/ACTWOglG5GlgzaL9dO8b7T1TuB6agZuLks5qHs9sgaJpZM4CV0gA .