search

Strider-CD / strider-webhooks

Fire webhooks reporting build status
6 stars 9 forks source link

fix #4: add webhooks works #8

Closed marcuspoehls closed 9 years ago

marcuspoehls commented 9 years ago

This pull request fixes #4 and users can add webhooks again.

Problem Angular adds a $$hashkey property to the object used in ng-repeat loops to distinct and recognize changes on them. The object containing the new webhook information also contained the $$hashkey property while it was sent to the server. On server side, MongoDB doesn’t allow saving properties beginning with the $ symbol.

Fix Add track by $index to the Angular ng-repeat loop to avoid the creation of the $$hashkey object.

Additionally, I added a missing closing tag for the url input.

knownasilya commented 9 years ago

Deployed to plugins index.