search

Strider-CD / strider

Open Source Continuous Integration & Deployment Server
http://strider-cd.github.io/
4.59k stars 432 forks source link

Can port 3000 actually be overridden? #1068

Closed LaughingBubba closed 4 years ago

LaughingBubba commented 5 years ago

The docs mention use of the PORT environment to override the port used by express. However I'm not sure if this is working.

This came about because I noticed a github call back URL was prefixed with the default port of 3000 and failed for a project. I changed it in the browsers URL bar to 8888 and it worked.

I assumed it was because the environment variable wasn't explicitly set in the Dockerfile. But when I did, it broke my docker config.

My repo with the port overrides is here: https://github.com/LaughingBubba/strider-docker-service.git

Make sure you swtich to the "port" branch. The master branch is working but was the version that had the callback URL issue.

knownasilya commented 5 years ago

Did you connect to GitHub before setting the port?