search

Strider-CD / strider

Open Source Continuous Integration & Deployment Server
http://strider-cd.github.io/
4.59k stars 432 forks source link

fix: cleanup socket in LiveJob component #1087

Closed knownasilya closed 4 years ago

knownasilya commented 4 years ago

Make sure to disconnect the socket once the LiveJob component is unrendered. Currently this is not an issue since we only render one job in the Ember client, but once we move the dashboard to Ember it will be more important to prevent memory leaks.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/knownasilya1/strider/he1tuth2j ✅ Preview: https://strider-git-fix-cleanup-socket.knownasilya1.now.sh