test pull requests - Githubissues

Strider-CD / strider

Open Source Continuous Integration & Deployment Server

http://strider-cd.github.io/

4.6k stars 432 forks source link

test pull requests #124

Closed jaredly closed 10 years ago

jaredly commented 11 years ago

This would be so awesome.

My thought would be:

if sandboxing is enabled for the repo (by docker or the like) then test all pull requests
if not, then only test PRs by owners or "whitelisted" users. When a non-whitelisted user makes a PR, strider would comment on it and ask "should I test this?" An owner could then reply with either "test" or "test and whitelist".

Man, githubs APIs are crazy awesome. You can setup webhooks for pretty much anything.

niallo commented 11 years ago

Yeah, this is totally doable with Github APIs. You've probably noticed that Github pull requests have special Travis integration. I'm not sure if that is open to any 3rd part app or if Travis have had stuff added just for them.

In any case, this would be awesome! We'd need to add a few new properties in the DB schema, and some logic in the simple worker to actually be able to checkout the code in the pull-requests - but not that much.

jaredly commented 11 years ago

It's totally open to 3rd party apps :) https://github.com/blog/1227-commit-status-api

On Fri, Jul 19, 2013 at 10:34 AM, niallo notifications@github.com wrote:

Yeah, this is totally doable with Github APIs. You've probably noticed that Github pull requests have special Travis integration. I'm not sure if that is open to any 3rd part app or if Travis have had stuff added just for them.

In any case, this would be awesome! We'd need to add a few new properties in the DB schema, and some logic in the simple worker to actually be able to checkout the code in the pull-requests - but not that much.

— Reply to this email directly or view it on GitHubhttps://github.com/Strider-CD/strider/issues/124#issuecomment-21261083 .

sqs commented 11 years ago

niallo commented 11 years ago

Added to 1.4.x milestone

niallo commented 10 years ago

Should be done in 1.4. Could use testing.