Strider-CD / strider

Open Source Continuous Integration & Deployment Server
http://strider-cd.github.io/
4.6k stars 432 forks source link

Buttons don’t work in project configuration, can’t save anything #180

Closed cobyism closed 11 years ago

cobyism commented 11 years ago

Decided to try this out this morning via Vagrant/Docker with docker pull strider/strider.

Server is all up and running, and have created a project just fine, however I’m unable to configure any aspect of the project:

I see the following error in my browser’s JS console (using chrome version 29.0.1547.65):

Error: Argument 'EnvironmentCtrl' is not a function, got undefined
    at assertArg (http://localhost:6161/javascripts/lib/angular.js:1063:11)
    at assertArgFn (http://localhost:6161/javascripts/lib/angular.js:1073:3)
    at http://localhost:6161/javascripts/lib/angular.js:5365:9
    at http://localhost:6161/javascripts/lib/angular.js:4937:17
    at forEach (http://localhost:6161/javascripts/lib/angular.js:155:20)
    at nodeLinkFn (http://localhost:6161/javascripts/lib/angular.js:4922:11)
    at compositeLinkFn (http://localhost:6161/javascripts/lib/angular.js:4550:15)
    at compositeLinkFn (http://localhost:6161/javascripts/lib/angular.js:4553:13)
    at compositeLinkFn (http://localhost:6161/javascripts/lib/angular.js:4553:13)
    at nodeLinkFn (http://localhost:6161/javascripts/lib/angular.js:4953:24) angular.js:6349
(anonymous function) angular.js:6349
(anonymous function) angular.js:5420
Scope.$apply angular.js:9008
(anonymous function) angular.js:1004
invoke angular.js:2925
resumeBootstrapInternal angular.js:1002
bootstrap angular.js:1017
angularInit angular.js:977
(anonymous function) angular.js:16872
n jquery-1.7.1.min.js:2
o.fireWith jquery-1.7.1.min.js:2
e.extend.ready jquery-1.7.1.min.js:2
c.addEventListener.B jquery-1.7.1.min.js:2

Note: I’m running strider with the environment variable PORT=6161 set instead of 3000 due to a conflict with another app on my dev machine.

I had a quick look for other related issues, and this looks like this might be similar to #164 (even though that one got fixed).

niallo commented 11 years ago

Can you confirm this is 1.3.5? Thanks for the report.

Sent from my iPhone

On Sep 4, 2013, at 1:26 PM, Coby Chapple notifications@github.com wrote:

Decided to try this out this morning via Vagrant/Docker with docker pull strider/strider.

Server is all up and running, and have created a project just fine, however I’m unable to configure any aspect of the project:

Can’t specify Heroku API key, because the "Ok" button doesn’t work. Can’t add environment variables, the "Add" button triggers the cog in the corner to spin, but nothing ever happens. Can’t specify any custom scripts for prepare/test/deploy, the "Save" button doesn’t do anything. I see the following error in my browser’s JS console (using chrome version 29.0.1547.65):

Error: Argument 'EnvironmentCtrl' is not a function, got undefined at assertArg (http://localhost:6161/javascripts/lib/angular.js:1063:11) at assertArgFn (http://localhost:6161/javascripts/lib/angular.js:1073:3) at http://localhost:6161/javascripts/lib/angular.js:5365:9 at http://localhost:6161/javascripts/lib/angular.js:4937:17 at forEach (http://localhost:6161/javascripts/lib/angular.js:155:20) at nodeLinkFn (http://localhost:6161/javascripts/lib/angular.js:4922:11) at compositeLinkFn (http://localhost:6161/javascripts/lib/angular.js:4550:15) at compositeLinkFn (http://localhost:6161/javascripts/lib/angular.js:4553:13) at compositeLinkFn (http://localhost:6161/javascripts/lib/angular.js:4553:13) at nodeLinkFn (http://localhost:6161/javascripts/lib/angular.js:4953:24) angular.js:6349 (anonymous function) angular.js:6349 (anonymous function) angular.js:5420 Scope.$apply angular.js:9008 (anonymous function) angular.js:1004 invoke angular.js:2925 resumeBootstrapInternal angular.js:1002 bootstrap angular.js:1017 angularInit angular.js:977 (anonymous function) angular.js:16872 n jquery-1.7.1.min.js:2 o.fireWith jquery-1.7.1.min.js:2 e.extend.ready jquery-1.7.1.min.js:2 c.addEventListener.B jquery-1.7.1.min.js:2 Note: I’m running strider with the environment variable PORT=6161 set instead of 3000 due to a conflict with another app on my dev machine.

I had a quick look for other related issues, and this looks like this might be similar to #164 (even though that one got fixed).

— Reply to this email directly or view it on GitHub.

cobyism commented 11 years ago

Derp—It turns out I had actually been running this just by cloning Strider-CD/strider (i.e. the master branch) locally, not via docker like I initially said (I had originally been trying that, but must have gotten frustrated, given up, and switched over to a local clone instead).

I was able to get everything working by checking out the code tagged at 1.3.5 (using git checkout 1.3.5, for any poor souls reading this in the future), re-running npm install, and then restarting the server.

Sorry about the bogus report! :grin: :heart:

niallo commented 11 years ago

I'm glad that it doesn't happen in 1.3.5, but it is still a valid bug in HEAD (which will become 1.4.0).

Re-opening.

cobyism commented 11 years ago

but it is still a valid bug in HEAD (which will become 1.4.0).

:cool: Fair enough. Yes, this is was happening (for me) in the current master branch as of this morning, so if this is going to turn into a future release it should probably be sorted out before then :+1:

niallo commented 11 years ago

This is fixed in HEAD now. Thanks for the report!