search

Strider-CD / strider

Open Source Continuous Integration & Deployment Server
http://strider-cd.github.io/
4.59k stars 432 forks source link

Github Enterprise Support #220

Open sontek opened 10 years ago

sontek commented 10 years ago

Since the github plugin already exists and enterprise has all the same exact APIs, could we get the ability to configure the github plugin for multiple hosts? It should work exactly the same except for different URL roots.

jaredly commented 10 years ago

that's a great idea.

Jared

On Sat, Oct 19, 2013 at 7:29 PM, John Anderson notifications@github.comwrote:

Since the github plugin already exists and enterprise has all the same exact APIs, could we get the ability to configure the github plugin for multiple hosts? It should work exactly the same except for different URL roots.

— Reply to this email directly or view it on GitHubhttps://github.com/Strider-CD/strider/issues/220 .

mikesplain commented 10 years ago

+1, that would be awesome!

niallo commented 10 years ago

Isn't this already implemented, just not through the UI?

sontek commented 10 years ago

I should clean up my branch and send a PR, its not complicated but we need to refactor a little to make the configuration easier

jaredly commented 10 years ago

There was some thought about making it a separate plugin for clarity's sake. The "strider-github-enterprise" could simply import strider-github but have a different plugin id and a slightly modified config page

niallo commented 10 years ago

For sure. I like @jaredly's idea.

longlho commented 10 years ago

Do we have any updates on this? Would be great if I can use Strider for my org's GH Enterprise :+1:

agenteo commented 9 years ago

@niallo I'd love to know if github enterprise integration is far more difficult than regular github. Many CI servers out there don't have GH Enterprise. Feel free to PM me I don't want to hijack this thread :) thanks

kfatehi commented 9 years ago

@agenteo No reason not to keep it public -- there's no "hijacking threads" here, this issue is dedicated to GH Enterprise support. @sontek any news on that PR?

I don't know any developers of Strider that actually use GH enterprise, so we rely on the community to build the solution and contribute it. @jaredly and @niallo have offered guidance on how to do it -- someone just needs to do it and share it publicly. No secrecy here.

samartioli commented 9 years ago

Strider Does NOT work with GitHub Enterprise. Which is fine... IF you take down that you Do work with GitHub Enterprise.

You say right in your repo you work with GitHub Enterprise as well as in your documentation, but in fact Strider DOES NOT work with GitHub enterprise at this point.

The code is a little too spaghetti for me to try and take the time to add in the functionality myself.

knownasilya commented 9 years ago

@samartioli I'm not aware of Strider advertising support for GH enterprise. Where have you seen otherwise?

samartioli commented 9 years ago

I was wrong in it saying it supported Enterprise in the ReadMe on the repo, but it does say so in the docs.

http://strider.readthedocs.org/en/latest/intro.html#github-github-enterprise-bitbucket

knownasilya commented 9 years ago

That needs to be removed from the README. It's way too outdated.