Closed knownasilya closed 9 years ago
probably, might need to discuss the solution w/ @jaredly as I think he might have already had a path in mind -- maybe he'll want to code it now that we're adding react, otherwise yeah im sure i can do it
@jaredly what do you think of forcing population of mandatory fields (like DOCKER_HOST, etc) using something like this http://prometheusresearch.github.io/react-forms/ to interactively build the form based on a schema from the backend, defined by the plugin API ? maybe too complex but might work well ?
cc @niallo
Is the issue here that we don't currently have a way to mark certain fields in the project config as required?
On Wednesday, August 27, 2014, Keyvan Fatehi notifications@github.com wrote:
cc @niallo https://github.com/niallo
— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/542#issuecomment-53580459.
Niall O'Higgins W: http://niallohiggins.com E: n@niallo.me T: @niallohiggins
Right. There are two questions here as I understand it:
1) What the UI around Docker config should be. 2) How the UI should be implemented at a technical level (e.g. React Forms, jQuery, Angular).
In my opinion, the important stuff for 1) is that we make it clear that the Docker runner won't be usable until certain config variables are set (e.g. DOCKER_HOST). In terms of design, a clear message (perhaps warning or error-themed) would be appropriate.
For 2) I don't really care. React Forms or Angular or jQuery or whatever. I'm in favour of re-doing the UI in React but I don't have the bandwidth myself.
On Wed, Aug 27, 2014 at 9:32 AM, Keyvan Fatehi notifications@github.com wrote:
@niallo https://github.com/niallo this Strider-CD/strider-docker-runner#16 https://github.com/Strider-CD/strider-docker-runner/issues/16
— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/542#issuecomment-53601480.
Niall O'Higgins W: http://niallohiggins.com E: n@niallo.me T: @niallohiggins
We can get away with never addressing / organically addressing number 2.
I will address number 1 and get docker prepped for core.
On Wednesday, August 27, 2014, niallo notifications@github.com wrote:
Right. There are two questions here as I understand it:
1) What the UI around Docker config should be. 2) How the UI should be implemented at a technical level (e.g. React Forms, jQuery, Angular).
In my opinion, the important stuff for 1) is that we make it clear that the Docker runner won't be usable until certain config variables are set (e.g. DOCKER_HOST). In terms of design, a clear message (perhaps warning or error-themed) would be appropriate.
For 2) I don't really care. React Forms or Angular or jQuery or whatever. I'm in favour of re-doing the UI in React but I don't have the bandwidth myself.
On Wed, Aug 27, 2014 at 9:32 AM, Keyvan Fatehi <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:
@niallo https://github.com/niallo this Strider-CD/strider-docker-runner#16 https://github.com/Strider-CD/strider-docker-runner/issues/16
— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/542#issuecomment-53601480.
Niall O'Higgins W: http://niallohiggins.com E: n@niallo.me javascript:_e(%7B%7D,'cvml','n@niallo.me'); T: @niallohiggins
— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/542#issuecomment-53602618.
Sweet! El ago 27, 2014 10:44 AM, "Keyvan Fatehi" notifications@github.com escribió:
We can get away with never addressing / organically addressing #2.
I will address #1 and get docker prepped for core.
On Wednesday, August 27, 2014, niallo notifications@github.com wrote:
Right. There are two questions here as I understand it:
1) What the UI around Docker config should be. 2) How the UI should be implemented at a technical level (e.g. React Forms, jQuery, Angular).
In my opinion, the important stuff for 1) is that we make it clear that the Docker runner won't be usable until certain config variables are set (e.g. DOCKER_HOST). In terms of design, a clear message (perhaps warning or error-themed) would be appropriate.
For 2) I don't really care. React Forms or Angular or jQuery or whatever. I'm in favour of re-doing the UI in React but I don't have the bandwidth myself.
On Wed, Aug 27, 2014 at 9:32 AM, Keyvan Fatehi <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:
@niallo https://github.com/niallo this Strider-CD/strider-docker-runner#16 https://github.com/Strider-CD/strider-docker-runner/issues/16
— Reply to this email directly or view it on GitHub < https://github.com/Strider-CD/strider/issues/542#issuecomment-53601480>.
Niall O'Higgins W: http://niallohiggins.com E: n@niallo.me javascript:_e(%7B%7D,'cvml','n@niallo.me'); T: @niallohiggins
— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/542#issuecomment-53602618.
— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/542#issuecomment-53603060.
@keyvanfatehi can this be closed?
Yeah it's ready for 1.6.x and on
According to the roadmap this is scheduled for 1.5.1.
@keyvanfatehi think you can tackle this?