search

Strider-CD / strider

Open Source Continuous Integration & Deployment Server
http://strider-cd.github.io/
4.6k stars 432 forks source link

Use one templating library #689

Open knownasilya opened 9 years ago

knownasilya commented 9 years ago

Currently we have swig (outdated/deprecated) and jade. We should pick a templating library and work with that.

Currently jade is used in the emails. Possibly also in plugins. Swig is used everywhere else (server side rendered templates).

niallo commented 9 years ago

Definitely get rid of jade. I am not sure why it is still used anywhere - we must've had a couple of places which weren't converted.

Swig is good but does need updating. It has changed a fair amount in the latest version.

On Tuesday, January 13, 2015, Ilya Radchenko notifications@github.com wrote:

Currently we have swig (outdated/deprecated) and jade. We should pick a templating library and work with that.

Currently jade is used in the emails. Possibly also in plugins. Swig is used everywhere else (server side rendered templates).

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/689.

Niall O'Higgins W: http://niallohiggins.com E: n@niallo.me T: @niallohiggins

jaredly commented 9 years ago

yup. I think jade is only used in the emails. we can nix it

microadam commented 9 years ago

Think it may have been me who added them as part of the email templates. Not sure if they were there already before I modularised them.

Curious as to what your issues with Jade are though? Best templating system I have used in node!

On 13 Jan 2015, at 16:01, Jared Forsyth notifications@github.com wrote:

yup. I think jade is only used in the emails. we can nix it

— Reply to this email directly or view it on GitHub.

knownasilya commented 9 years ago

Not so much an issue with jade, just an extra dependency and learning curve, since we are using swig extensively.

microadam commented 9 years ago

Figured as much. Best to keep things consistent!

On 13 Jan 2015, at 18:32, Ilya Radchenko notifications@github.com wrote:

Not so much an issue with jade, just an extra dependency and learning curve, since we are using swig extensively.

— Reply to this email directly or view it on GitHub.