search

Strider-CD / strider

Open Source Continuous Integration & Deployment Server
http://strider-cd.github.io/
4.59k stars 432 forks source link

Manual Add form does not enable the Create New button #691

Open mingfang opened 9 years ago

mingfang commented 9 years ago

I'm trying to add a github project using the Manual Add form. In the form I fill in these values Display Url: https://github.com/Strider-CD/strider Name: Strider-CD/strider Url: https://github.com/Strider-CD/strider.git

But the Create New button remains disabled and not clickable. I'm running v1.6.0 inside Docker https://github.com/mingfang/docker-stridercd Also, other projects using my github account works fine; Just having problem with Manual Add

fernandoneto commented 9 years ago

in the url you must use ssh address of your repo. make the test and worked for me

mingfang commented 9 years ago

So I was able to get it to work by first selecting Http but didn't fill in the authentication info. The Create New button got enabled and I was able to add and build the project. The prepare stage says this git clone --recursive http://[username]:[password]@github.com/Strider-CD/strider.git Which is a result of not adding any authentication info. I'm surprise that works at all. Anyway it works, just not very user friendly.

kfatehi commented 9 years ago

Thanks @mingfang -- we'll leave this open for investigation later -- we definitely want it to be user friendly / intuitive. If you can think of a specific way to improve the behavior of the form, your contribution is very welcome.

knownasilya commented 9 years ago

@mingfang it says git clone --recursive http://[username]:[password]@github.com/Strider-CD/strider.git because that is the "safe" version of the url, i.e. it doesn't expose the credentials. IT will show that even if you didn't put any credentials in.