Strider-CD / strider

Open Source Continuous Integration & Deployment Server
http://strider-cd.github.io/
4.59k stars 432 forks source link

Errors cloning repo and running tests #989

Open samuelcolvin opened 7 years ago

samuelcolvin commented 7 years ago

I'm attempting to clone a repo and run tests with a strider.json config file and getting numerous errors.

After adding the project via github I go to the build page and get the following messages: screenshot from 2016-09-06 20-10-44

with a job.error.message.substr(0,10000) error message.

If I then try to run tests I get no output and the page appears to hang, no errors show in the terinal running strider. screenshot from 2016-09-06 20-11-42

Attempts to kill the build have no effect:

screenshot from 2016-09-06 20-12-29

If I kill the build manually by stopping and starting strider, then try building the repo again but this time from the build page (this build option isn't available directly after you clone a repo apparently), i get the following error log:

screenshot from 2016-09-06 20-13-13

This message seems to only appear the first time the page is loaded and if you start the build directly from that page, if i reload the page I get the blank window as above.

I running the head of master de7244e636d5981d746c722c9db1adc747a8e558 on Linux CI 4.5.7-docker-4 #1 SMP Tue Jul 12 09:41:14 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux eg. the standard docker image from scaleway.

Tell me I'm doing something very simple and obvious wrong and strider doesn't always give this number of errors?

oliversalzburg commented 7 years ago

The behavior regarding the build output is a known and very unfortunate bug that affects builds which fail very soon after being started.

How did you add the project? It seems like the generated public key was not properly registered with GitHub. This is usually done automatically when you're adding a project through Strider.

Also, make sure to set the variable DEBUG to strider* in the Strider environment.

knownasilya commented 7 years ago

Usually has to do with SERVER_NAME not being set (or being incorrect) when first setting up the provider (github, gitlab, bitbucket,..) authentication.

samuelcolvin commented 7 years ago

I had an issue with github redirecting to localhost:3000 when trying to authenticate even though I had setup SERVER_NAME so I created a new github app which seemed to fix that problem.

AFAIK I had SERVER_NAME correct all along.

oliversalzburg commented 7 years ago

@samuelcolvin So, are the builds working now? You need to add the project again otherwise. The deployment keys are only registered when adding the project.

samuelcolvin commented 7 years ago

No the build doesn't work. I'll try to have another go another time, think I've hit my limit strider for today.

xgalen commented 7 years ago

I am having a similar issue. The difference is we are not using the strider.json file.

Here is the output (with urls changed):

Mon, 17 Oct 2016 16:12:25 GMT strider:routes:api:repo Setting up new project "myrepo"...
Mon, 17 Oct 2016 16:12:25 GMT strider:ssh Generating SSH key pair...
Mon, 17 Oct 2016 16:12:29 GMT strider:routes:api:repo Setting up repository "myrepo" with provider "github"...
2016-10-17T16:12:29.318Z - error: Mon, 17 Oct 2016 16:12:29 GMT strider-github:api CREATE WEBHOOK URL: https://api.github.com/repos/myrepo/hooks http://mystrider.com/myrepo/api/github/webhook
Mon, 17 Oct 2016 16:12:29 GMT strider:http PUT /myrepo/ 200 4192.276 ms - 195
2016-10-17T16:12:29.466Z - error: Mon, 17 Oct 2016 16:12:29 GMT strider-github:webhooks got a body: { payload:

When I click the Refresh account button got this, although the list is shown (not fully well):

Mon, 17 Oct 2016 16:17:20 GMT strider:routes:projects Fetching projects...
Mon, 17 Oct 2016 16:17:20 GMT strider:routes:projects Now trying to list repos for the following provider for an account in the user model: github
2016-10-17T16:17:20.844Z - error: Mon, 17 Oct 2016 16:17:20 GMT strider-github:api PAGINATED API CALL URL: https://api.github.com/user/repos
2016-10-17T16:17:20.844Z - error: Mon, 17 Oct 2016 16:17:20 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/user/repos
2016-10-17T16:17:20.845Z - error: Mon, 17 Oct 2016 16:17:20 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2
2016-10-17T16:17:20.845Z - error: Mon, 17 Oct 2016 16:17:20 GMT strider-github:api PAGINATED API CALL URL: https://api.github.com/user/orgs
2016-10-17T16:17:20.846Z - error: Mon, 17 Oct 2016 16:17:20 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/user/orgs
2016-10-17T16:17:20.846Z - error: Mon, 17 Oct 2016 16:17:20 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2
2016-10-17T16:17:20.971Z - error: Mon, 17 Oct 2016 16:17:20 GMT strider-github:api PAGINATED API CALL URL: https://api.github.com/user/repos
2016-10-17T16:17:20.971Z - error: Mon, 17 Oct 2016 16:17:20 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/user/repos
2016-10-17T16:17:20.971Z - error: Mon, 17 Oct 2016 16:17:20 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2
2016-10-17T16:17:21.022Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api API CALL: https://api.github.com/orgs/mediasmart/teams 3f40a75fd7a2903c69d0150100b551ef063a6d0f
2016-10-17T16:17:21.022Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/orgs/mediasmart/teams
2016-10-17T16:17:21.022Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2
2016-10-17T16:17:21.057Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api API CALL: https://api.github.com/teams/1102853 3f40a75fd7a2903c69d0150100b551ef063a6d0f
2016-10-17T16:17:21.058Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/teams/1102853
2016-10-17T16:17:21.058Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2
2016-10-17T16:17:21.058Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api API CALL: https://api.github.com/teams/2090656 3f40a75fd7a2903c69d0150100b551ef063a6d0f
2016-10-17T16:17:21.059Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/teams/2090656
2016-10-17T16:17:21.059Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2
2016-10-17T16:17:21.060Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api API CALL: https://api.github.com/teams/1102852 3f40a75fd7a2903c69d0150100b551ef063a6d0f
2016-10-17T16:17:21.060Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/teams/1102852
2016-10-17T16:17:21.060Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2
2016-10-17T16:17:21.061Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api API CALL: https://api.github.com/teams/1102859 3f40a75fd7a2903c69d0150100b551ef063a6d0f
2016-10-17T16:17:21.061Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/teams/1102859
2016-10-17T16:17:21.061Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2
2016-10-17T16:17:21.062Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api API CALL: https://api.github.com/teams/1102902 3f40a75fd7a2903c69d0150100b551ef063a6d0f
2016-10-17T16:17:21.062Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/teams/1102902
2016-10-17T16:17:21.063Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2
2016-10-17T16:17:21.063Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api API CALL: https://api.github.com/teams/1578535 3f40a75fd7a2903c69d0150100b551ef063a6d0f
2016-10-17T16:17:21.063Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/teams/1578535
2016-10-17T16:17:21.063Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2
2016-10-17T16:17:21.064Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api API CALL: https://api.github.com/teams/1102861 3f40a75fd7a2903c69d0150100b551ef063a6d0f
2016-10-17T16:17:21.065Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api GET OAUTH2 URL: https://api.github.com/teams/1102861
2016-10-17T16:17:21.065Z - error: Mon, 17 Oct 2016 16:17:21 GMT strider-github:api Inside get_oauth2: Callback type: function Number of arguments expected by: 2

Adding a fresh repo to Strider with two plugins (custom-scripts and github-status) and clicking Test, says:

2016-10-17T16:20:51.193Z - error: Mon, 17 Oct 2016 16:20:51 GMT strider-github-status initing 5804fa63f142f28011465adf undefined
2016-10-17T16:20:51.196Z - error: Mon, 17 Oct 2016 16:20:51 GMT strider-github-status No github PR data undefined { __v: 0,

And after that, the same error described by @samuelcolvin about error 500 and public key.

All this tests are done with the latest commit merged and running: https://github.com/Strider-CD/strider/commit/52f15a443a0433d83aefacd6f3307083d360ba44

Any help would be appreciated, thanks.

oliversalzburg commented 7 years ago

@xgalen It seems like registering the webhook already fails. Which indicates insufficient access privileges.

xgalen commented 7 years ago

Yes, that seems but: The repo has the same permissions that those others that are working. The repo has the Strider's webhook added and it's marked ok. Is there other place where I have to set the privileges?

xgalen commented 7 years ago

Finally I made it works with adding the project's ssh key to the organization. The weird is the other old projects are still working and don't need this.

knownasilya commented 7 years ago

Probably related to https://github.com/Strider-CD/strider-github/pull/69

xgalen commented 6 years ago

@samuelcolvin did you make strider work?