search

StripesFramework / stripes

Stripes is a Java framework with the goal of making Servlet/JSP based web development in Java as easy, intuitive and straight-forward as it should be. It's stripey and it doesn't suck.
http://www.stripesframework.org/
171 stars 73 forks source link

#41 - Don't run Doclint for javadoc for JDK 8 #42

Closed jccarrillo closed 8 years ago

jccarrillo commented 8 years ago

Circumvents issue #41 by not running the doclint for javadoc when building with jdk8

jccarrillo commented 8 years ago

@bengunter, @vankeisb, @lmeadors you have modified this pom.xml, please have a look at this patch as this will allow users to build stripes with jdk 8.

vankeisb commented 8 years ago

Hi, I did that change locally but I think it breaks the 1.7 build, which we use for releasing. I left it as is since it's a "good thing",or at least it has its advantage : it prevents to ship a 1.8 compiled jar... So I'm OK with the change but it has to build (release profile) with 1.7, and it'd be nice to fail the release build if java > 1.7.

jccarrillo commented 8 years ago

@vankeisb, do you use the "maven release plugin" to release a build?

vankeisb commented 8 years ago

Not sure. I don't have the code right here but we inherit a parent pom from Sonatype, which allows us to release.

You can try it out in 1.7 by activating the "release" profile.

jccarrillo commented 8 years ago

The last commit does the trick you wanted. I will squash before any merge. Waiting for any comments.

vankeisb commented 8 years ago

Why skip gpg ?

jccarrillo commented 8 years ago

I skipped it based on jdk1.8 and the build failed as before. It will prevent shipping with a 1.8 build.

jccarrillo commented 8 years ago

@vankeisb thanks for accepting the patch

vankeisb commented 8 years ago

My pleasure !