search

StripesFramework / stripes

Stripes is a Java framework with the goal of making Servlet/JSP based web development in Java as easy, intuitive and straight-forward as it should be. It's stripey and it doesn't suck.
http://www.stripesframework.org/
171 stars 73 forks source link

stripes 1.7b3 ignoring validationErrorHandler #60

Closed jpsantos-tests closed 8 years ago

jpsantos-tests commented 8 years ago

Hi,

relatively new to github and Stripes, which btw rocks. Using latest Stripes' beta, noticed that if a Restactionbean implements ValidationErrorHandler where the validation method returns my resolution, it gets ignored. I've noticed PR https://github.com/StripesFramework/stripes/pull/56 which seems related, but I don't know Stripes internals that well, so i don't really know.

How can I return a custom resolution on an error when executing a RestActionBean, how may I proceed?

Many thanks in advance, pierre

vankeisb commented 8 years ago

Hi Pierre,

Although I haven't tried it myself, it definitely looks like the bug described by Juan Pablo. I can't merge his fix right now because a test is failing, but I guess it'll be fixed soon. I'll do another release then.

In the meantime, if this is a blocker for you, maybe you can just do the validation logic right inside your even handler method (ie add errors to the ActionBeanContext and/or return a Resolution of your own) ?

HTH

Rémi

2016-06-15 16:12 GMT+02:00 currupipi-smith notifications@github.com:

Hi,

relatively new to github and Stripes, which btw rocks. Using latest Stripes' beta, noticed that if a Restactionbean implements ValidationErrorHandler where the validation method returns my resolution, it gets ignored. I've noticed PR #56 https://github.com/StripesFramework/stripes/pull/56 which seems related, but I don't know Stripes internals that well, so i don't really know.

How can I return a custom resolution on an error when executing a RestActionBean, how may I proceed?

Many thanks in advance, pierre

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/StripesFramework/stripes/issues/60, or mute the thread https://github.com/notifications/unsubscribe/AAbwwgdMrIIIuQLmu9-y1HwbO-r3j370ks5qMAhIgaJpZM4I2Zk3 .

jpsantos-tests commented 8 years ago

Hi Rémi,

thanks for your prompt response, will do as advised until the new beta is out.

cheers, Pierre

jpsantos-tests commented 8 years ago

Hi,

closing the issue as 1.7.0-beta4 is out.

cheers, Pierre