Stromberg90 / Scripts

MIT License
199 stars 78 forks source link

Boundary "loop" selection + selection state cleanup #15

Closed MightyBOBcnc closed 4 years ago

MightyBOBcnc commented 4 years ago

Hi, me again. I added a new function for selecting a boundary edge "loop" of connected edges like Maya's selection of a mesh's Border Edges. It only selects the "loop" that is connected to the starting edge, not every boundary edge on the mesh.

There are two (three?) design questions that maybe should be answered. 1: Should there be a Preference to enable/disable this? I can see how some users would prefer for the boundary edge selection to terminate at corners or 'poles' where more than 2 faces connect at a boundary vertex but if the goal is to emulate Maya, well Maya doesn't terminate; it grabs the full border edge "loop". 2: The way the function is implemented right now it will only select up to 1000 edges in a boundary edge loop which is kind of a performance/safety failsafe. Do we think that is okay or should we make it unlimited and let the user take responsibility for any performance issues? 2a: If we think a limit is sensible for performance reasons, should that be configurable in a preference or left at 1000?


I also added a couple more selection flushes to keep the selection state 'happy' the way Blender likes, updated the author line, and the version number.

Stromberg90 commented 4 years ago

I'm happy to see this getting improved :) I don't think we need a preference for this, since this is how it's supposed to work, however if people complain about it later, then yeah we can add that. Also think we can get rid off the edge limit, and if it becomes a problem see if we can speed it up, I feel a limit might make people(myself included) think that it's broken or something.

MightyBOBcnc commented 4 years ago

Alright, edge limit removed. Should be green for testing and merge.