search

StrongJoshua / libgdx-inGameConsole

A LibGdx library that allows a developer to add a console (similar to how it is featured in Source games) to their game.
https://www.strongjoshua.net/projects/games/libgdx-ingame-console
Apache License 2.0
132 stars 34 forks source link

Update GUIConsole #23

Closed BenMcLean closed 7 years ago

BenMcLean commented 7 years ago

GUIConsole needs to update the viewport inside the stage when the screen resizes, such as switching between full screen and windowed mode. The console becomes unusable if this is not done.

Also, I expanded the gitignore a bit.

BenMcLean commented 7 years ago

Also updated your maven to generate sources jar. This is needed for GWT support when distributing over Jitpack

BenMcLean commented 7 years ago

Since GWT doesn't support the tilde key, and most function keys will already have a meaning for the browser, I have made the key that turns the console on and off modifiable and I have changed the default key to APOSTROPHE.

StrongJoshua commented 7 years ago

The refresh function should have already accomplished switching view modes issue, setting the keyID was already possible with setDisplayKeyID(), and the default character was TAB, not tilde, but I appreciate the maven changes.

BenMcLean commented 7 years ago

Tab doesn't work on the web either, as it switches control away from the game to other things on the web page.

StrongJoshua commented 7 years ago

Alright, I'll keep it as apostrophe then.

BenMcLean commented 7 years ago

Actually, what I'd suggest is expanding the API so as to allow the program to specify any bindimg they think appropriate. Let them send in an anonymous function or whatever, and provide a default one that is tab or whatever.

Might also be good to have a console command to close the console.

On Mar 27, 2017 11:19 PM, "Jan Risse" notifications@github.com wrote:

Alright, I'll keep it as apostrophe then.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/StrongJoshua/libgdx-inGameConsole/pull/23#issuecomment-289658661, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqpMo__7xVa4FM6ZL7sBg9G9RryBJigks5rqIpXgaJpZM4Lf_GD .

StrongJoshua commented 7 years ago

I'm not sure what you mean by using an anonymous function, the API already allows for the console to be shown/hidden programmatically.

A function like that can be easily implemented by anyone that uses the console.

BenMcLean commented 7 years ago

Is there a way to redefine / rebind at runtime which key or key combo opens and closes the console? That's what's needed IMO.

Finding out how inconsistent different browsers are about which keys are and aren't available to JavaScript programs was real frustrating. W3C should have taken care of this IMO but haven't.

On Mar 27, 2017 11:30 PM, "Jan Risse" notifications@github.com wrote:

I'm not sure what you mean by using an anonymous function, the API already allows for the console to be shown/hidden programmatically.

A function like that can be easily implemented by anyone that uses the console.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/StrongJoshua/libgdx-inGameConsole/pull/23#issuecomment-289659849, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqpMmBcqR-ki0a7Ud6ihqqyXgg0gDTKks5rqIzXgaJpZM4Lf_GD .

StrongJoshua commented 7 years ago

Yes, use the setDisplayKeyID() function in GUIConsole.