search

StrongJoshua / libgdx-inGameConsole

A LibGdx library that allows a developer to add a console (similar to how it is featured in Source games) to their game.
https://www.strongjoshua.net/projects/games/libgdx-ingame-console
Apache License 2.0
132 stars 34 forks source link

Added additional getter to GUIConsole #39

Closed Blunderchips closed 6 years ago

Blunderchips commented 6 years ago

Added a getter for the console window. Returns the actual scene2d window After the toFront method.

This change should give users more control over the physical GUI window.

StrongJoshua commented 6 years ago

See, I can never decide with these functions that only target a GUI enabled console. Do I add them to the interface or not? But that's what I've been doing for now, so this function should work the same. Amend your commit so it conforms and I'll merge it in.

Blunderchips commented 6 years ago

I amended the commit so it conforms as requested.

StrongJoshua commented 6 years ago

Sorry I messed up my explanation. I meant that this would be a function inherited from the Console Interface with an empty implementation in AbstractConsole and the correct implementation in GUIConsole (take a look at setHoverColor for example).

I don't think the function should move the window to the front. The user can do that themselves when they get the Window object.

Blunderchips commented 6 years ago

I understand now, will make the change in the morning.

Blunderchips commented 6 years ago

Will do in a new PR.