search

StrongJoshua / libgdx-inGameConsole

A LibGdx library that allows a developer to add a console (similar to how it is featured in Source games) to their game.
https://www.strongjoshua.net/projects/games/libgdx-ingame-console
Apache License 2.0
132 stars 34 forks source link

GUI Console Constructor with a Stage #42

Closed Blunderchips closed 5 years ago

Blunderchips commented 6 years ago

Added a new constructor in the GUI Console class that accepts a Stage as a parameter. There needs to be some way to attach the console to a pre-existing stage, rather than create a new stage. At the moment, whenever a new GUI console is instantiated a new Stage is created. For projects that already have a Stage, there should be some way to make the console use that Stage.

I would suggest creating a new constructor in the GUI Console class that accepts a Stage as a parameter.

StrongJoshua commented 6 years ago

Why do you think this is necessary? Everything already works even when there is an existing stage. The console uses an input multiplexer to manage input events, which is the only conflict that can really arise.

Blunderchips commented 6 years ago

If there is an existing stage why not make use of it? If for no other reason, consistency's sake.

StrongJoshua commented 6 years ago

That would require a bit more adjusting than just adding a constructor. A lot of the resizing of the console is managed by the stage it is in. And consistent with what? What do you mean?

StrongJoshua commented 5 years ago

No follow-up. Closing this issue.