search

StronzLabs / Stronzflix

Application for streaming multimedia content
https://stronzlabs.github.io/Stronzflix/
GNU General Public License v3.0
15 stars 6 forks source link

Add Subtitle Scrolling with Italian Language Priority and Resizable Title Bar Widgets #9

Closed xKvIcHa77x closed 3 months ago

Bonfra04 commented 3 months ago

Thanks a lot for the PR. Great ideas!

I like the scrolly thing in the subtitles tab, can you abstract it to a higher level and put it as a wrapper in the current selected setting page? so it'll work for any setting page, regardless of its implementation

About the resizable title bug, there is a bug: The layout process in Flutter works by splitting the remaining space equally among all of the flexible widgets. The fitted box inside the flexible you added shares the row with the spaces used to align to the left the cast and chat buttons. This means that the title can get incredibly small in specific scenarios: image If the spacer is removed (and the cast button isn't aligned) the text adjusts correctly as you intended image Also, can you expand this title adjustment to the desktop controls as well?

I'll be very happy to accepts your PR as soon as you fix these little things

Bonfra04 commented 3 months ago

Hi, I think your auto formatter got in the way for lib/components/player/desktop_video_controls.dart, and all the indentation tabs were changed. It is impossible this way to review the commit and understand what changed and what did not. Can you fix it and mark this PR as ready for review?

DefEnge commented 3 months ago

Hi @xKvIcHa77x even though your commits are quite explicit about what they do, it is almost impossible to review the code you wrote due to the fact that the auto formatter changes almost every line of said files. And having a few files with different formmatting is quite frustrating. So please be sure to stick with the current formatting and alter only the necessary part of the code. As reference the behavior on the screenshot should not happen. (Sorry for the rudeness we are trying to keep the code clear to read and consistent in each file).