search

StructJuMP / StructJuMP.jl

A block-structured optimization framework for JuMP
Other
54 stars 19 forks source link

strict requirements? #25

Closed kibaekkim closed 7 years ago

kibaekkim commented 8 years ago

StructJuMP requires to install both PIPS-NLP and Ipopt. To me this is quite strict, because StructJuMP potentially could support any solver. The solvers are used in StructJuMPSolverInterface, even where they seem not necessary. Moreover, MPI.jl could also be optional in StructJuMP.

Can we relax these requirements (PIPS-NLP, Ipopt, and MPI.jl)?

blegat commented 8 years ago

I agree with @kibaekkim IMHO StructJuMP would benefit from staying more at the modelling level. In the REQUIRE, it is said to need MPI and in the README, it is said to need PIPS and Ipopt while in StochasticDualDynamicProgramming, I use StructJuMP without needing any of MPI, PIPS or Ipopt. I do not think that it is a big issue to require MPI (I may require it in https://github.com/blegat/StochasticDualDynamicProgramming in the future anyway) but it may be clearer to move a part of the README to StructJuMPSolverInterface if it is specific to that project and just mention in the README that StructJuMP is a modeling interface that is used by several project such as StructJuMPSolverInterface and StochasticDualDynamicProgramming and could also be used for many other different purposes (any modeling that need parent-children structure). Of course, I might be misinterpreting the whole project so correct me if I am wrong.

joehuchette commented 8 years ago

I agree that the requirements are overly strict. I will try to take a stab this weekend at cleaning this up (along with some of the other open issues).

kibaekkim commented 8 years ago

@joehuchette I have already removed a quite on my local. I can create a new branch and put my code there, if you give me an access to create a branch.

mlubin commented 8 years ago

@kibaekkim, you don't need write permission for this repo, you can just make a fork

kibaekkim commented 8 years ago

@mlubin I already have a folk that keeps a old version of StochJuMP that can still run without PIPS. And Github does not allow me to have two folks for the same project.

mlubin commented 8 years ago

@kibaekkim, you should be able to push a new branch to your fork without disrupting what you already have there

joehuchette commented 8 years ago

@kibaekkim I believe you already have write access, can you test this out?

kibaekkim commented 8 years ago

@mlubin Ah! that should work. @joehuchette Yes, now I can create a branch. Thanks!

blegat commented 8 years ago

I see you have create the remove-pips branch. Can it be merged ? I like the fact that MPI is removed from the REQUIRE file :)

blegat commented 7 years ago

@kibaekkim This can be closed now :)

kibaekkim commented 7 years ago

@blegat Thanks!