Export Benders #47 - Githubissues

StructJuMP / StructJuMP.jl

A block-structured optimization framework for JuMP

Other

54 stars 19 forks source link

Export Benders #47 #49

Closed blegat closed 7 years ago

coveralls commented 7 years ago

Coverage remained the same at 79.648% when pulling ce57b33eb23f4ea2f1c085ebef1ce2be933e7a8b on blegat:doubleinclude into 616588ae3ce6b3f564fdb1ecfbff51bedae2cce4 on StructJuMP:master.

ktarplee commented 7 years ago

Should the public functions from BendersBridge.jl instead be exported by StructJuMP.jl? Then those if statements could be removed (and the include replaced with "using StructJuMP"). See #47

blegat commented 7 years ago

@ktarplee Agreed, I have update the PR.

coveralls commented 7 years ago

Coverage decreased (-0.05%) to 79.597% when pulling 795d8f0b6ee64b350f07553e6dae2cf9956a91f6 on blegat:doubleinclude into 616588ae3ce6b3f564fdb1ecfbff51bedae2cce4 on StructJuMP:master.

joehuchette commented 7 years ago

Looks fine with me, good to merge once travis is passing.

blegat commented 7 years ago

The Travis failure is only on Mac OS nightly and is unrelated to this PR