search

StructJuMP / StructJuMP.jl

A block-structured optimization framework for JuMP
Other
54 stars 19 forks source link

Use JuMP's functions to simplify conicconstraintdata and add SDP support #50

Closed blegat closed 7 years ago

blegat commented 7 years ago

We need https://github.com/JuliaOpt/JuMP.jl/pull/1023 to be merged for this PR to work

joehuchette commented 7 years ago

I think JuliaOpt/JuMP.jl#1023 qualifies as a bug fix, so we could/should have a new patch release.

mlubin commented 7 years ago

@joehuchette it's fixing a bug that was never in any release IIRC. That doesn't necessarily trigger a new release.

joehuchette commented 7 years ago

Possibly, I was trying to trace the lineage but got lost.

blegat commented 7 years ago

Could we register StructJuMP once this PR is merged ?

joehuchette commented 7 years ago

Releasing should probably wait for a compatible released version of JuMP. @blegat what JuMP commits does this rely on? If it's not invasive we could potentially cherry-pick onto a new patch release. Or just release a new JuMP version, any objections @mlubin?

mlubin commented 7 years ago

I can't be involved in any JuMP releases before June 5th (thesis). But I'd be ok with tagging 0.17 once the currently active PRs go through.

blegat commented 7 years ago

I have rebased the PR so that it no longer checkout JuMP and I have added JuMP v0.17 as a dependency :)

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.5%) to 77.855% when pulling e424675345629d53179d68445cb3971b957aa025 on blegat:conicdata into 2abc9b3b3385d9da554c905e44f60b324b02cf6e on StructJuMP:master.

joehuchette commented 7 years ago

Good to merge once Travis clears!

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.5%) to 77.855% when pulling e424675345629d53179d68445cb3971b957aa025 on blegat:conicdata into 2abc9b3b3385d9da554c905e44f60b324b02cf6e on StructJuMP:master.

blegat commented 7 years ago

Travis succeeds on v0.5 and the failure on nightly/v0.7 is due to compilation errors on dependencies. The coverage has decreased because a lot of lines removed where covered. However the number of lines missed has decreased too ! :)

blegat commented 7 years ago

What about registering StructJuMP now that this PR is merged ? :)

joehuchette commented 7 years ago

Sounds good! I won't be able to tag and register before this weekend, but feel free to do it yourself.

blegat commented 7 years ago

Thanks! Unfortunately, I don't have the sufficient rights to do it :(

joehuchette commented 7 years ago

I added you as collaborator, which should fix that.

blegat commented 7 years ago

Thanks :)