search

StructJuMP / StructJuMP.jl

A block-structured optimization framework for JuMP
Other
54 stars 19 forks source link

StructuredConstraintRef struct seems unnecessary #71

Closed jmaack24 closed 4 years ago

jmaack24 commented 5 years ago

The JuMP.ConstraintRef struct allows takes the model type as a parameterized type provided it is a subtype of JuMP.AbstractModel. Since this is true of StructuredModel, it seems unnecessary to create a StructJuMP specialized version of this struct.

More importantly, because there is no abstract super type for JuMP.ConstraintRef, StructJuMP's usage of its own specialized constraint reference struct means that code cannot easily work with a JuMP.Model or a StructJuMP.StructuredModel easily.

blegat commented 5 years ago

That makes sense, it can be replaced by ConstraintRef{StructuredModel, Int, <:AbstractShape}.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days