search

Structed / godot-playfab

A Godot Engine addon/SDK to interface with Azure PlayFab - playfab.com
MIT License
124 stars 14 forks source link

Process Mode init in _ready #122

Open JEuler opened 1 year ago

JEuler commented 1 year ago

Hey, cool addon! I found a problem when I was using it. I've tried to upload results in my own Autoload script and found that PlayfabManager is not working in Pause mode. Is that made intentionally?

Structed commented 1 year ago

Thank you very much for your contribution, @JEuler! In fact, I never thought about pause mode, so the change is much appreciated!

I would, however, ask you to add a test example to the Example Scenes. Could you do that?

JEuler commented 1 year ago

Hey! Thanks! But I don't know what to do in the text example scene for this change. I just faced an issue, that when you have get_tree().paused = true - my own helper class which used the PlayFabManager stopped working. I have added this line to my own class at first with no luck, but after some thinking - I come up with this solution and all worked.

JEuler commented 1 year ago

Hey! Should I just create test example where I pause something, and the Plugin stopped working? :)

Structed commented 11 months ago

I am so sorry for the long wait! life and not reading my notifications cam in between 😬

Well, I imagine a pause button, while in the background you can still see the checks for whether events are batched to be sent (shown in console).

Another thing to consider is, that the mode should really be settable by the developer via the Plugin config. But I suppose that can be a separate task.

Structed commented 11 months ago

Thinking about this more: this change would introduce a breaking change. In order to not make this breaking, this must be a project setting that defaults to PROCESS_MODE_INHERIT.