search

StructuralNeurobiologyLab / SyConn

Toolkit for the generation and analysis of volume eletron microscopy based synaptic connectomes of brain tissue.
http://structuralneurobiologylab.github.io/SyConn/
GNU General Public License v2.0
40 stars 9 forks source link

Downsample Not Saved #29

Closed william-silversmith closed 4 years ago

william-silversmith commented 4 years ago

Hi! Just wanted to point out that the PrecomputedSkeleton.downsample function is performed on a copy. You need to write skels[ii] = skels[ii].downsample(10) for it to have an effect.

https://github.com/StructuralNeurobiologyLab/SyConn/blob/c471a69d94a9ef1b0435e5e37036ca31810a4aaf/syconn/proc/skeleton.py#L73

pschubert commented 4 years ago

Hi William, thanks for noticing! That reminds me that I need to merge our development branch to the master as soon as possible. Here is what we do currently: https://gitlab.mpcdf.mpg.de/pschuber/SyConn/-/blob/ptconv/syconn/proc/skeleton.py#L79

I will close this issue once I pushed the changes to the master.

pschubert commented 4 years ago

fixed in commit https://github.com/StructuralNeurobiologyLab/SyConn/commit/e2803341a56a8f1bcd56091b16e0cf5d2a454ca7 .