search

Strum / Strums_Mental_VCV_Modules

Strum's Mental Modules for VCV Rack
BSD 3-Clause "New" or "Revised" License
63 stars 15 forks source link

v1: plugin.json issues #45

Closed cschol closed 5 years ago

cschol commented 5 years ago

The validation script found the following issues during integration:

[Strums_Mental_VCV_Modules] Issues found in `plugin.json`:

MentalMixer: invalid module tags: Stereo
MentalSubMixer: invalid module tags: Stereo
MentalFold: invalid module tags: Fold
MentalClip: invalid module tags: Clip
MentalGates: invalid module tags: Gate, Mute
MentalQuantiser: invalid module tags: Quantiser
MentalChord: invalid module tags: Chord, Harmony
MentalButtons: invalid module tags: Control, Button
MentalSums: invalid module tags: Sum
MentalPitchShift: invalid module tags: Pitch Shift
MentalMux8: invalid module tags: Multiplexer
MentalCounters: invalid module tags: Counters
MentalKnobs: invalid module tags: Control
MentalRadioButtons: invalid module tags: Button
-- Valid tags are defined in https://github.com/VCVRack/Rack/blob/v1/src/plugin.cpp#L534
mocmichal commented 5 years ago

https://github.com/VCVRack/Rack/blob/v1/src/tag.cpp

cschol commented 5 years ago

Ah, thanks. I should update my script.

Strum commented 5 years ago

I expected this issue, hadn't seen the list of allowed tags, will fix. cheers

cschol commented 5 years ago

All good. Thanks.