search

Strum / Strums_Mental_VCV_Modules

Strum's Mental Modules for VCV Rack
BSD 3-Clause "New" or "Revised" License
63 stars 15 forks source link

Rendering issues in 1.0.x? #56

Closed cschol closed 3 years ago

cschol commented 4 years ago

The LFO looks different in 1.0 than it did in 0.6. For example, the backgrounds of the faders are missing in 1.0.

v0.6.x: image

v1.0.x: image

Is this a plugin rendering issue or did the module design change?

neoh4x0r commented 3 years ago

Seems to be by-design: https://github.com/Strum/Strums_Mental_VCV_Modules/blob/master/src/MentalQuadLFO.cpp#L266 https://github.com/VCVRack/Rack/blob/a5fc58910bcdfdd6babd77bafad7bbe142ac939a/include/componentlibrary.hpp#L531

It's just the green slider -- with no background shading.

It might be nice to have the background shading on there -- because the initial position of the sliders (at 0) is the bottom on slider bank and there is a lot of distance between the green leds and the sliders

There is another issue #5 asking for help with making some modules (if not all) look better. Towards the bottom there was @Anthony-Lockwood who changed the background of the quad lfo and added a black-rectangle behind the sliders to make them easier to see.

In all honestly, those elements are stored in the svg resources -- inkscape is great tool for editing them.