search

Strumenta / SmartReader

SmartReader is a library to extract the main content of a web page, based on a port of the Readability library by Mozilla
https://smartreader.inre.me
Apache License 2.0
160 stars 36 forks source link

Improve code quality #27

Closed iamcarbon closed 3 years ago

iamcarbon commented 3 years ago

This PR focuses on reducing allocations, virtual calls, and culture specific comparisons.

gabriele-tomassetti commented 3 years ago

Thanks for your great contribution!

I have a question, though. I have seen that you have updated the language version to 9.0. Will this work on .NET Core 3.0, which supports the .NET Standard 2.1?

iamcarbon commented 3 years ago

Yes! C#9 is can be used when targeting any .NET runtime or standard abstraction (including netcore3.0 and net451)! C#9 contains quite a few nice syntax improvements.

The language flag also enables a few new runtime features (e.g. default interfaces and init only properties) - but the project won’t compile if the target framework is missing support.

On Apr 21, 2021, at 6:14 AM, Gabriele Tomassetti @.***> wrote:

 Thanks for your great contribution!

I have a question, though. I have seen that you have updated the language version to 9.0. Will this work on .NET Core 3.0, which supports the .NET Standard 2.1?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.