Strumenta / SmartReader

SmartReader is a library to extract the main content of a web page, based on a port of the Readability library by Mozilla
https://smartreader.inre.me
Apache License 2.0
160 stars 36 forks source link

Improve Code Quality 2 #28

Closed iamcarbon closed 3 years ago

iamcarbon commented 3 years ago

This PR:

iamcarbon commented 3 years ago

Ready for review.

gabriele-tomassetti commented 3 years ago

Thanks for the thorough review of the code.

I originally did try to mantain a syntax close to the original JavaScript to make easier to port any new change from upstream. The less change there is, the easier is to add updates. My concern was to avoid the common case of abandoned ports because of a mix of a lack of interest and too much effort required. I wanted to make sure to be able to keep the pace.

However, most people seemed to prefer a more C#-native style and we already heavily improved the overall organization of the code. So it make sense to also improve the syntax of the code. All this to say: thanks for your improvements to bring a more C#-native syntax to the library.