search

Strumenta / antlr-kotlin

Support for Kotlin as a target for ANTLR 4
Apache License 2.0
222 stars 47 forks source link

Publish on Maven Central #109

Closed ftomassetti closed 9 months ago

lppedd commented 9 months ago

Before publishing, do we want to change package names?

Currently the runtime lives under org.antlr.v4.kotlinruntime, which is totally fine, however, what about moving to org.antlr.v4.runtime to align with Java?
The benefit would be an easy switch from the Java world, as the only thing you'd have to do would be convert your custom listeners/visitors to Kotlin (e.g., using the IDE converter).

Not sure if there are downsides to having the same package tho.

ftomassetti commented 9 months ago

I see your point, but I am also afraid of having conflicting classes. There are projects where we use multiple parsers. If we were using a parser based on the java target and one based on the kotlin target and both runtimes would reside in the same package I wonder if we risked having classes with the exact same name and causing havoc because of that. Also, if someone is debugging some code could be useful to immediately figure out if the problem comes from the Java or the Kotlin runtime

lppedd commented 9 months ago

Makes sense! Then forget about it.