Strumenta / antlr-kotlin

Support for Kotlin as a target for ANTLR 4
Apache License 2.0
227 stars 47 forks source link

Add missing property overrides in generated code and fix XPath impl #120

Closed lppedd closed 10 months ago

lppedd commented 10 months ago

We had a couple missing overrides in generated lexers and parsers: serializedATN and modeNames.

I've also fixed the XPath implementation to use a generated lexer, which is what all targets do beside the Java one (which for some reason didn't get updated).

lppedd commented 10 months ago

Let me rebase this one on master before merging, so I can re-verify with the new testing.

lppedd commented 10 months ago

@ftomassetti ready for review and merge.

ftomassetti commented 10 months ago

Looks good to me, merging. I will then do a new release