Strumenta / antlr-kotlin

Support for Kotlin as a target for ANTLR 4
Apache License 2.0
221 stars 47 forks source link

Enable the linuxArm32Hfp Native target #143

Closed lppedd closed 7 months ago

lppedd commented 7 months ago

Other Kotlin libraries, like kotlinx-serialization, had to enable back the linuxArm32Hfp target.
That target is still present, so we should also build for it.

See https://github.com/Kotlin/kotlinx.serialization/pull/2505

lppedd commented 7 months ago

@ftomassetti you can review anytime. Had to adjust the readme.

ftomassetti commented 7 months ago

I would like to get #144 solved before merging other PRs

lppedd commented 7 months ago

@ftomassetti this one can wait, but #146 will block people using certain grammars.
Hopefully the missing person will give permission too.

ftomassetti commented 7 months ago

We are down to one, so I think that either way we will move forward in a matter of days

ftomassetti commented 7 months ago

In general it looks good but I would like to understand better why supporting a deprecated target: don't we risk having to remove support in the near future? If so, can we just avoid adding it in the first place?