search

Strumenta / antlr-kotlin

Support for Kotlin as a target for ANTLR 4
Apache License 2.0
221 stars 47 forks source link

Releasing ANTLR Kotlin _also_ under the BSD-3 clause #144

Closed ftomassetti closed 7 months ago

ftomassetti commented 7 months ago

Dear @lppedd @drieks @phyrian @exaV @OldWartHog @brianguertin @atsushieno @tianyu @tim-patterson @alchitry @oleg-zinovev @ianparkinson @garyttierney @frett @wilkomanger @unosviluppatore

I am writing about your contributions to ANTLR Kotlin. A project that I originally started in 2017 and that benefitted from your help.

ANTLR Kotlin is released under the Apache License 2.

However a team designing ANTLR 5 is considering including components of ANTLR Kotlin in their project. It could end up being used only for experiments, or, as I hope, became the basis of ANTLR 5. The reason for this choice is that the ANTLR Kotlin runtime can be compiled to WASM.

I think it would be an amazing possibility to contribute to the new generation of ANTLR and make our work more valuable. For that the team behind ANTLR 5 requested if you would consider granting the license to your work also under the BSD-3 license. The differences between the two licenses seem minimal to me. What I am proposing is one of these alternatives.

So I am studying how to satisfy this request, while letting users of ANTLR Kotlin keep using future releases of ANTLR Kotlin under the Apache License 2, if they wish to do so. So there would be no changes for them.

Based on your answers there are three possible scenarios:

Scenario 1: ANTLR Kotlin under both licenses

If we get the approval from all the authors (or the authors of 99%+ of the commits) then we will:

Scenario 2: ANTLR Kotlin as-is, plus "revisited fork"

If we get the approval from most of the authors (or the authors of 95%+ of the commits) then we will:

Scenario 3: We do not proceed

If we do not the approval from most of the authors then we will drop this possibility:

What do I need from you?

To answer this issue stating that you grant me the possibility to release your contributions to ANTLR Kotlin also under the BSD-3 License, or alternatively to send me an email about that.

I am sorry to disturb you with this boring discussion about licenses and I am thankful for your contributions to the ANTLR Kotlin project. It has been providing value to different adopters during these years, and the fact we have the possibility to provide even more value is a great thing that you made possible.

Cheers, Federico

ftomassetti commented 7 months ago

I have also reached some of you by email, if you had your emails available on GitHub

garyttierney commented 7 months ago

OK from me to license any contributions I've made under BSD-3.

OldWartHog commented 7 months ago

Federico,

I hereby grant you permission to release any contributions I have made under the terms of either the Apache2 or BSD-3 licence

And I’m really happy to see the project grow, so well done in creating and maintaining this project.

Martin

On 11 Jan 2024, at 10:01, Federico Tomassetti @.***> wrote:

I have also reached some of you by email, if you had your emails available on GitHub

— Reply to this email directly, view it on GitHub https://github.com/Strumenta/antlr-kotlin/issues/144#issuecomment-1886761788, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABADZR6WOXGOLNEIMY3ZDFDYN62ABAVCNFSM6AAAAABBWGOSV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBWG43DCNZYHA. You are receiving this because you were mentioned.

ianparkinson commented 7 months ago

That's really exciting!

I'm happy for my trivial contribution to antlr-kotlin to be released under BSD-3.

On Thu, 11 Jan 2024, 10:10 Martin, @.***> wrote:

Federico,

I hereby grant you permission to release any contributions I have made under the terms of either the Apache2 or BSD-3 licence

And I’m really happy to see the project grow, so well done in creating and maintaining this project.

Martin

On 11 Jan 2024, at 10:01, Federico Tomassetti @.***> wrote:

I have also reached some of you by email, if you had your emails available on GitHub

— Reply to this email directly, view it on GitHub < https://github.com/Strumenta/antlr-kotlin/issues/144#issuecomment-1886761788>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABADZR6WOXGOLNEIMY3ZDFDYN62ABAVCNFSM6AAAAABBWGOSV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBWG43DCNZYHA>.

You are receiving this because you were mentioned.

— Reply to this email directly, view it on GitHub https://github.com/Strumenta/antlr-kotlin/issues/144#issuecomment-1886777632, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWJBXMYVRIZ67VMIS4WHSDYN63A5AVCNFSM6AAAAABBWGOSV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBWG43TONRTGI . You are receiving this because you were mentioned.Message ID: @.***>

ftomassetti commented 7 months ago

Thank you @garyttierney @ianparkinson and @OldWartHog I also got permission by @unosviluppatore and @lppedd by email

drieks commented 7 months ago

Hi, its also fine for me to use both licenses!

atsushieno commented 7 months ago

I happily relicense my contributions under the BSD-3 license too (replied in the email too).

oleg-zinovev commented 7 months ago

Hi. OK from me to license my contribution under BSD-3.

exaV commented 7 months ago

Hey, thanks for reaching out. Great to see the project grow! You may licence my contributions under BSD-3 as well.

tianyu commented 7 months ago

Yes! Please use my work on this project under the BSD-3 license!

phyrian commented 7 months ago

Sure, feel free to use my contributions under BSD-3 as well.

ftomassetti commented 7 months ago

Thank you all, I appreciate it!

At this point we got permissions from the contributors of 414 commits out of 425 (97.41%). Let's see if we can get the permissions from the remaining 5 contributors.

alchitry commented 7 months ago

It's fine with me to release my contributions under BSD-3. I'd love to see this make its way into ANTLR.

ericvergnaud commented 7 months ago

Gents, as the lead of the antlr5 project, I thank you all for your rapid approval. The antlr5-specs repo will soon go public, and the antlr5 code repo will be created soon after that. You are more than welcome to contribute. Since we're opting for a mono-repo, originally forked from the antrl4 repo, it might impact how we integrate the ANTLR Kotlin code base. Let me know if you have ideas on how to make this work in the best interest of everybody. Also, and very importantly, since antlr5 will require WasmGC, which is currently only available in V8 (chrome, deno and node in a few months) ANTLR Kotlin will not be replaced any time soon. So I encourage you to continue investing in it, and to help figure out how to ensure these contributions make it to antlr5.

lppedd commented 7 months ago

it might impact how we integrate the ANTLR Kotlin code base. Let me know if you have ideas on how to make this work in the best interest of everybody

Thanks! Happy to contribute changes/suggestions for the build system.
I'll wait for the ANTLR5 spec repo to go public and then have a look at it.

We'll continue improving the multiplaform support, especially around JS/Wasm/WASI support, as soon as ideas come up (and as Kotlin evolves).
Ideally all platforms should match the original Java runtime semantics.

frett commented 7 months ago

I'm good with my contributions being released under BSD-3

wilkomanger commented 7 months ago

Hi, I was mentioned but I've only opened issues, don't you think you need my approval!

ftomassetti commented 7 months ago

Hi, I was mentioned but I've only opened issues, don't you think you need my approval!

wilkomanger, you have actually contributed a commit a few years ago, so yes, we need your approval

Edit: here it is the commit https://github.com/Strumenta/antlr-kotlin/commit/121fb9ef5a2ca82b47b43fcd28b611bd69497ff1

wilkomanger commented 7 months ago

Ah sorry, weird, couldn't find it before. Then yes I give permission 👍

ftomassetti commented 7 months ago

Ok, also Tim granted us permissions to do the change. We are missing a single contributor (Brian). I will try to ping him and see if we can get permissions also from him.

I never thought we could reach this point so quickly. Thank you to all of you for your prompt support!

brianguertin commented 7 months ago

Also OK from me to license any contributions I've made under BSD-3.

ftomassetti commented 7 months ago

Thank you all! This was a chance to get in chance with all of you and thank you for your contributions.

I opened a PR to specify that the code is now available also under BSD: #147

ftomassetti commented 7 months ago

Change to the licensing model done. Thank you once more!

ftomassetti commented 6 months ago

As a follow-up: thanks to your help the code you provided has now been included in ANTLR5. The merge has been done in a way to preserve the git history. This meant a lot of work for the person who did it, but it also means that all of you now appear among the contributors to ANTLR5.

Development of ANTLR Kotlin will continue for years to come, until ANTLR5 is fully stable and users have migrated to it.