Use escaped names where possible

Strumenta / antlr-kotlin

Support for Kotlin as a target for ANTLR 4

Apache License 2.0

221 stars 47 forks source link

Closed lppedd closed 7 months ago

lppedd commented 7 months ago

Testing the MySQL grammar, which uses object as a token label in the parser, I've noticed not all names were escaped.

Better visual diff:

ftomassetti commented 7 months ago

Would it make sense to combine changes in https://github.com/antlr/antlr5/pull/8 with these?

lppedd commented 7 months ago

@ftomassetti I'd say we could join the changes to name > escapedName, I've seen you've added a bunch of them.

Feel free to add other commits to this PR, or open another PR which also includes the changes in this one.

ftomassetti commented 7 months ago

I will get this one merged and open a separate issue for back-porting stuff. Thank you Edoardo!