search

Strumenta / antlr-kotlin

Support for Kotlin as a target for ANTLR 4
Apache License 2.0
227 stars 47 forks source link

Add a linter #24

Open ftomassetti opened 5 years ago

ftomassetti commented 5 years ago

In this way we do not have to review for styles issues

sschuberth commented 9 months ago

Probably Detekt with KtLint-based formatting rules enabled?

sschuberth commented 9 months ago

I just found this discussion, but just as a remark, of course KtLint is way more Kotlin-specific style checks than .editorconfig, and via Detekt it's also not "a PITA" to configure anymore.

lppedd commented 9 months ago

My point for preferring Editorconfig over tools like KTLint (and Detekt) is simplicity, both for the IDE and for build scripts.
With Detekt we're adding layers of additional complexities for simple formatting issues, which we solve nicely with the auto-recognized .editorconfig file.

Tools like Detekt are generally useful for big teams or a large number of contributors, but in this case we're not at that point and a simple CTRL+ALT+L (on Windows) fixes everything.